Update and refactor mesh generation #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
force-pushed
the
refactor-meshgen
branch
from
c9a0945 to
2230846
Compare
alexfikl
force-pushed
the
refactor-meshgen
branch
2 times, most recently
from
82349fa to
5ea7f08
Compare
|
This seems to work as expected, i.e. it builds the |
alexfikl
force-pushed
the
refactor-meshgen
branch
from
5ea7f08 to
46ef5ea
Compare
|
@xywei This should be good for a look when you have the time! It's also just a cleanup / modernize PR with no new functionality. |
alexfikl
force-pushed
the
refactor-meshgen
branch
from
46ef5ea to
f28b025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some work around the mesh generation modules (commits should be fairly self contained):
CMakeLists.txtforcontrib/meshgen11_dealiito mainly follow https://pybind11.readthedocs.io/en/stable/cmake/index.html. This also removed the vendoredpybind11module.dealiimodule on the CI so that tests can generate meshes.boxtreebased classes involumential/meshgen.pyto a separatemeshgen_boxtree.pyfile. The logic inmeshgen.pywas made very confusing by defining classes in thetry.. except, so hopefully this is better.There's still a
contrib/meshgen_dealiifolder. Can that be deleted?